linux-kernel - Re: [PATCHv5 3/5] mfd: motorola-cpcap: Add audio-codec support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180308125408.45jyq2poz7najqze@earth.universe>
Date:   Thu, 8 Mar 2018 13:54:08 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.co.uk>
To:     Lee Jones <lee.jones@...aro.org>, Rob Herring <robh+dt@...nel.org>,
        Mark Brown <broonie@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Tony Lindgren <tony@...mide.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...labora.com
Subject: Re: [PATCHv5 3/5] mfd: motorola-cpcap: Add audio-codec support

Hi,

On Thu, Mar 08, 2018 at 10:48:31AM +0000, Lee Jones wrote:
> On Thu, 08 Mar 2018, Sebastian Reichel wrote:
> > On Thu, Mar 08, 2018 at 09:53:15AM +0000, Lee Jones wrote:
> > > On Thu, 08 Mar 2018, Sebastian Reichel wrote:
> > > > On Wed, Mar 07, 2018 at 04:32:11PM +0000, Lee Jones wrote:
> > > > > On Fri, 23 Feb 2018, Sebastian Reichel wrote:
> > > > > > +static const struct mfd_cell cpcap_mfd_devices[] = {
> > > > 
> > > > [...]
> > > > 
> > > > > > +	}, {
> > > > > > +		.name          = "cpcap-led",
> > > > > > +		.id            = 4,
> > > > > > +		.of_compatible = "motorola,cpcap-led-cp",
> > > > > > +	}, {
> > > > > > +		.name          = "cpcap-codec",
> > > > > > +	}
> > > > > > +};
> > > > > 
> > > > > With none of the entries containing platform_data /me wonders why you
> > > > > can't still use devm_of_platform_populate()?
> > > > 
> > > > Because devm_of_platform_populate works with compatible properties and
> > > > cpcap-codec does not have one after I removed it for Mark.
> > > 
> > > Sorry, I missed that conversation.  Why was it removed?
> > 
> > I had it in PATCHv1-PATCHv4. It was removed, since Mark didn't want
> > to have it in the DT ABI.
> 
> Right, but why?  Is it not a hardware device?  I think converting from
> devm_of_platform_populate() for one sub-device is a bit drastic.

This must be answered by Mark. Personally I think it makes more sense
to have the compatible, since all other cpcap sub-devices have them
and it should be consistent IMHO. I changed it to avoid bikeshedding.

The previous discussion was here: https://patchwork.kernel.org/patch/10220035/

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)