linux-kernel - Re: [PATCH] hda: realtek: Make dock sound work on ThinkPad L570

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h371a913a.wl-tiwai@suse.de>
Date:   Thu, 08 Mar 2018 13:57:29 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Dennis Wassenberg" <dennis.wassenberg@...unet.com>
Cc:     "Hui Wang" <hui.wang@...onical.com>,
        "Jaroslav Kysela" <perex@...ex.cz>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hda: realtek: Make dock sound work on ThinkPad L570

On Thu, 08 Mar 2018 13:17:54 +0100,
Dennis Wassenberg wrote:
> 
> One version of Lenovo Thinkpad T570 did not use ALC298
> (like other Kaby Lake devices). Instead it uses ALC292.
> In order to make the Lenovo dock working with that codec
> the dock quirk for ALC292 will be used.
> 
> Signed-off-by: Dennis Wassenberg <dennis.wassenberg@...unet.com>

So, although the PCI SSID appears to be a new one, this still needs
the old quirk, not for T470 dock?  Just to be sure.


thanks,

Takashi

> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index b9c93fa..b5d0f8c 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6508,6 +6508,7 @@ enum {
>  	SND_PCI_QUIRK(0x17aa, 0x2245, "Thinkpad T470", ALC298_FIXUP_TPT470_DOCK),
>  	SND_PCI_QUIRK(0x17aa, 0x2246, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
>  	SND_PCI_QUIRK(0x17aa, 0x2247, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
> +	SND_PCI_QUIRK(0x17aa, 0x2249, "Thinkpad", ALC292_FIXUP_TPT460),
>  	SND_PCI_QUIRK(0x17aa, 0x224b, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
>  	SND_PCI_QUIRK(0x17aa, 0x224c, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
>  	SND_PCI_QUIRK(0x17aa, 0x224d, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
> -- 
> 1.9.1
> 
> 
>