linux-kernel - Re: [PATCH v2 2/3] platform/x86: dell-*: Add interface for switchable graphics status query

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DC881209-6C71-4B13-BF48-05F1F93E207A@canonical.com>
Date:   Fri, 9 Mar 2018 16:14:03 +0800
From:   Kai Heng Feng <kai.heng.feng@...onical.com>
To:     Pali Rohár <pali.rohar@...il.com>
Cc:     mjg59@...f.ucam.org, dvhart@...radead.org, andy@...radead.org,
        Mario Limonciello <mario.limonciello@...l.com>, tiwai@...e.com,
        platform-driver-x86@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        alsa-devel@...a-project.org
Subject: Re: [PATCH v2 2/3] platform/x86: dell-*: Add interface for switchable
 graphics status query



> On Mar 9, 2018, at 12:38 AM, Pali Rohár <pali.rohar@...il.com> wrote:
>
> On Thursday 08 March 2018 17:10:22 Kai-Heng Feng wrote:
>> +int dell_switchable_gfx_enabled(bool *enabled);
>
> What about following API?
>
> bool dell_switchable_gfx_is_enabled(void);
>
> Are you really interested in errors? Then what about?

Not really. We can assume it's false when there's any error.

I'll update the function in next version, thanks!

Kai-Heng

>
> int dell_switchable_gfx_is_enabled(void);
>
> with e.g.
>   < 0 - error
>   = 0 - disabled
>> 0 - enabled
>
> -- 
> Pali Rohár
> pali.rohar@...il.com