linux-kernel - Re: [PATCH v2] crypto/ecc: Remove stack VLA usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <470bdece-b9a6-17fa-5dec-f4dfec51ef73@microchip.com>
Date:   Fri, 9 Mar 2018 10:31:17 +0200
From:   Tudor Ambarus <tudor.ambarus@...rochip.com>
To:     Kees Cook <keescook@...omium.org>,
        Herbert Xu <herbert@...dor.apana.org.au>
CC:     "David S. Miller" <davem@...emloft.net>,
        <linux-crypto@...r.kernel.org>,
        <kernel-hardening@...ts.openwall.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] crypto/ecc: Remove stack VLA usage



On 03/08/2018 11:57 PM, Kees Cook wrote:
> On the quest to remove all VLAs from the kernel[1], this switches to
> a pair of kmalloc regions instead of using the stack. This also moves
> the get_random_bytes() after all allocations (and drops the needless
> "nbytes" variable).
> 
> [1]https://lkml.org/lkml/2018/3/7/621
> 
> Signed-off-by: Kees Cook<keescook@...omium.org>

Reviewed-by: Tudor Ambarus <tudor.ambarus@...rochip.com>