linux-kernel - Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a466d82b-2a0f-ffba-f9f7-c76c6c787bb5@arm.com>
Date:   Fri, 9 Mar 2018 10:53:14 +0000
From:   Suzuki K Poulose <Suzuki.Poulose@....com>
To:     Saravana Kannan <skannan@...eaurora.org>
Cc:     will.deacon@....com, mark.rutland@....com, robh@...nel.org,
        sudeep.holla@....com, mathieu.poirier@...aro.org,
        peterz@...radead.org, jonathan.cameron@...wei.com,
        linux-kernel@...r.kernel.org, marc.zyngier@....com,
        leo.yan@...aro.org, frowand.list@...il.com,
        linux-arm-kernel@...ts.infradead.org, rananta@...eaurora.org,
        avilaj@...eaurora.org,
        Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>,
        Charles Garcia-Tobin <Charles.Garcia-Tobin@....com>
Subject: Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

+ Cc: Lorenzo, Charles.

On 08/03/18 23:59, Saravana Kannan wrote:
> On 01/02/2018 03:25 AM, Suzuki K Poulose wrote:
>> Add support for the Cluster PMU part of the ARM DynamIQ Shared Unit (DSU).
>> The DSU integrates one or more cores with an L3 memory system, control
>> logic, and external interfaces to form a multicore cluster. The PMU
>> allows counting the various events related to L3, SCU etc, along with
>> providing a cycle counter.
>>
>> The PMU can be accessed via system registers, which are common
>> to the cores in the same cluster. The PMU registers follow the
>> semantics of the ARMv8 PMU, mostly, with the exception that
>> the counters record the cluster wide events.
>>
>> This driver is mostly based on the ARMv8 and CCI PMU drivers.
>> The driver only supports ARM64 at the moment. It can be extended
>> to support ARM32 by providing register accessors like we do in
>> arch/arm64/include/arm_dsu_pmu.h.
>>
>> Cc: Mark Rutland <mark.rutland@....com>
>> Cc: Will Deacon <will.deacon@....com>
>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
>> Reviewed-by: Mark Rutland <mark.rutland@....com>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@....com>

[...]

> 
> Looking at the code, I didn't see any specific handling of cluster power collapse. AFAIK, the HW counters do not retain config (what event they are counting) or value (the current count) across power collapse. Wouldn't you need to register for some kind of PM_ENTER/EXIT notifiers to handle that?

Good point, yes *somebody* needs to save-restore the registers. But who ? As far
as the kernel is concerned, it doesn't control the DSU states. Also, as of now
there is no reliable way to get the "ENTER/EXIT" notifications for the DSU power
domain state changes. All we do is use the PMU, assuming it is available. AFAIT,
it should really be done at EL3, which manages the DSU, but may be I am wrong.

Sudeep, Lorenzo, Charles,

Please feel free to share your thoughts.

Cheers
Suzuki