linux-kernel - Re: [PATCH] drivers: net: wireless: ath: ath9k: dfs: remove VLA usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb0bb0e5-e037-e006-ca11-45eb8a8aa1b7@gmail.com>
Date:   Fri, 9 Mar 2018 05:34:36 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Andreas Christoforou <andreaschristofo@...il.com>,
        keescook@...omium.org
Cc:     kernel-hardening@...ts.openwall.com,
        QCA ath9k Development <ath9k-devel@....qualcomm.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: net: wireless: ath: ath9k: dfs: remove VLA usage

On 03/09/2018 05:23 AM, Andreas Christoforou wrote:
> The kernel would like to have all stack VLA usage removed.
> 
> This is the correct patch.
> 
> Signed-off-by: Andreas Christoforou <andreaschristofo@...il.com>

This is a lazy changelog really.

'This is the correct patch' has no technical value.

What is VLA  ? Sure, _now_ its pretty clear since we have floods of 
these patches, but...

In one or two years, people reading it will not understand the logic of 
this patch.

I had to look at the source to understand what was going on, and that is 
not a good sign for a trivial patch like that.