linux-kernel - Re: [PATCH v3 1/3] clk: tegra: Mark HCLK, SCLK and EMC as critical

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92084f1b-848a-39e6-7d77-7ceaa6a6f1d3@gmail.com>
Date:   Fri, 9 Mar 2018 17:35:46 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Thierry Reding <thierry.reding@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...eaurora.org>
Cc:     Peter De Schrijver <pdeschrijver@...dia.com>,
        Prashant Gaikwad <pgaikwad@...dia.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        linux-clk@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] clk: tegra: Mark HCLK, SCLK and EMC as critical

On 08.03.2018 17:44, Thierry Reding wrote:
> On Thu, Mar 01, 2018 at 04:33:29PM +0300, Dmitry Osipenko wrote:
>> On 15.01.2018 13:56, Dmitry Osipenko wrote:
>>> On 10.01.2018 16:59, Dmitry Osipenko wrote:
>>>> Machine dies if HCLK, SCLK or EMC is disabled. Hence mark these clocks
>>>> as critical.
>>>>
>>>> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
>>>> Acked-by: Peter De Schrijver <pdeschrijver@...dia.com>
>>>> ---
>>>>
>>>> Change log:
>>>> v2:     Fixed accidentally missed marking EMC as critical on Tegra30 and
>>>>         Tegra124. Switched to a use of common EMC gate definition on Tegra20
>>>>         and Tegra30.
>>>>
>>>> v3:     Dropped marking PLL_P outputs as critical, because seems they are
>>>>         not so critical. Although, I still haven't got a definitive answer
>>>>         about what exact HW functions are affected by the fixed-clocks.
>>>>         Anyway it should be cleaner to correct the actual drivers.
>>>
>>> Stephen / Michael, would it be possible to schedule these patches for 4.16? My
>>> T20 and T30 devices aren't working without the 'critical clocks' patch. Things
>>> happen to work with the opensource u-boot, but not with the proprietary
>>> bootloader. It's probably not a big deal that out-of-tree devices are broken,
>>> although would be nice to have one problem less.
>>
>> Guys, is there anything I could do to get these patches in linux-next?
> 
> I've picked these up into the for-4.17/clk branch in the Tegra tree. I
> already have that branch for the MBIST patches which are a dependency
> for the for-4.17/soc branch.

Thank you very much! Could you please add stable tag to this ("Mark HCLK, SCLK
and EMC as critical") patch? It would be nice to have 4.16 unbroken eventually
for those who (have to) use downstream android bootloader.

Cc: <stable@...r.kernel.org> # v4.16

> Stephen, Mike, let me know if you have any objections to carrying these
> in the Tegra tree.