linux-kernel - Re: [PATCH 9/9] perf c2c report: Add cacheline address count column

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180309173441.GG8347@kernel.org>
Date:   Fri, 9 Mar 2018 14:34:41 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Jiri Olsa <jolsa@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        David Ahern <dsahern@...il.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH 9/9] perf c2c report: Add cacheline address count column

Em Fri, Mar 09, 2018 at 05:28:28PM +0100, Jiri Olsa escreveu:
> On Fri, Mar 09, 2018 at 11:56:43AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Mar 09, 2018 at 11:14:42AM +0100, Jiri Olsa escreveu:
> > > Adding the 'PA cnt' column grouped under data cacheline address.
> > > 
> > > It shows how many times the physical addresses changed for the
> > > hist entry. It does not show the number of different physical
> > > addresses for entry, because we don't store those. We only track
> > > the number of times we got different address than we currently
> > > hold, which is not expensive and gives similar info.
> > > 
> > >   $ perf c2c report --stdio
> > > 
> > >   #        ----------- Cacheline ----------    Total      Tot  ----- LLC Load Hitm -----
> > >   # Index             Address  Node  PA cnt  records     Hitm    Total      Lcl      Rmt
> > >   # .....  ..................  ....  ......  .......  .......  .......  .......  .......
> > >   #
> > 
> > 
> > I'm adding this to the docs, ack?
> 
> nope.. those fields are c2c report only.. hardcoded
> 
> I'm preparing a change to share c2c fields with the
> general report.. should come with other perf mem
> changes later

Ok, dropping that then
 
> jirka
> 
> > 
> > diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
> > index cba16d8a970e..f4a280428e28 100644
> > --- a/tools/perf/Documentation/perf-report.txt
> > +++ b/tools/perf/Documentation/perf-report.txt
> > @@ -127,7 +127,7 @@ OPTIONS
> >  
> >  	If the --mem-mode option is used, the following sort keys are also available
> >  	(incompatible with --branch-stack):
> > -	symbol_daddr, dso_daddr, locked, tlb, mem, snoop, dcacheline.
> > +	symbol_daddr, dso_daddr, locked, tlb, mem, snoop, dcacheline, dcacheline_count.
> >  
> >  	- symbol_daddr: name of data symbol being executed on at the time of sample
> >  	- dso_daddr: name of library or module containing the data being executed
> > @@ -137,6 +137,7 @@ OPTIONS
> >  	- mem: type of memory access for the data at the time of the sample
> >  	- snoop: type of snoop (if any) for the data at the time of the sample
> >  	- dcacheline: the cacheline the data address is on at the time of the sample
> > +	- dcacheline_count: the number of physical addresses sampled for this dcacheline
> >  	- phys_daddr: physical address of data being executed on at the time of sample
> >  
> >  	And the default sort keys are changed to local_weight, mem, sym, dso,