linux-kernel - Re: [PATCH] perf vendor events arm64: Enable JSON events for ThunderX2 B0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKTKpr6XBqBMA0yfauwMxpfMzcvy6LO0hgZMhnebSrCmHu7dOg@mail.gmail.com>
Date:   Fri, 9 Mar 2018 23:37:04 +0530
From:   Ganapatrao Kulkarni <gklkml16@...il.com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
Cc:     Will Deacon <will.deacon@....com>,
        William Cohen <wcohen@...hat.com>, mark.rutland@....com,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        John Garry <john.garry@...wei.com>,
        linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Robert Richter <Robert.Richter@...ium.com>,
        Ingo Molnar <mingo@...hat.com>, jnair@...iumnetworks.com,
        Ganapatrao Kulkarni <ganapatrao.kulkarni@...ium.com>,
        Jiri Olsa <jolsa@...hat.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] perf vendor events arm64: Enable JSON events for
 ThunderX2 B0

On Fri, Mar 9, 2018 at 11:32 PM, Arnaldo Carvalho de Melo
<arnaldo.melo@...il.com> wrote:
> Em Fri, Mar 09, 2018 at 03:00:40PM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Fri, Mar 09, 2018 at 11:15:16PM +0530, Ganapatrao Kulkarni escreveu:
>> > On Fri, Mar 9, 2018 at 11:03 PM, Arnaldo Carvalho de Melo
>> > > +++ b/tools/perf/pmu-events/arch/arm64/mapfile.csv
>> > > @@ -13,5 +13,5 @@
>> > >  #
>> > >  #Family-model,Version,Filename,EventType
>> > >  0x00000000410fd03[[:xdigit:]],v1,arm/cortex-a53,core
>> > > -0x00000000420f5160,v1,cavium/thunderx2,core
>> > > +0x00000000430f0af0,v1,cavium/thunderx2,core
>> > >  0x00000000480fd010,v1,hisilicon/hip08,core
>
>> > please do not delete existing entry,  add additional entry.
>> > > +0x00000000430f0af0,v1,cavium/thunderx2,core
>
>> Ok, my bad, I think my eyes are failing me, I swear I saw them in the
>> original patch, which is not the case...
>
>> Ok, will add, together with Will's Acked-by
>
> So this is how it ended up:
>
>
> commit 9245299469de2e02d9c3cb167c0e52f75f1cc180
> Author: Ganapatrao Kulkarni <ganapatrao.kulkarni@...ium.com>
> Date:   Wed Mar 7 16:38:03 2018 +0530
>
>     perf vendor events arm64: Enable JSON events for ThunderX2 B0
>
>     There is MIDR change on ThunderX2 B0, adding an entry to mapfile to
>     enable JSON events for B0.
>
>     Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@...ium.com>
>     Acked-by: Will Deacon <will.deacon@....com>
>     Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
>     Cc: Ganapatrao Kulkarni <gpkulkarni@...kml16.com>
>     Cc: Jayachandran C <jnair@...iumnetworks.com>
>     Cc: Jiri Olsa <jolsa@...hat.com>
>     Cc: John Garry <john.garry@...wei.com>
>     Cc: Mark Rutland <mark.rutland@....com>
>     Cc: Peter Zijlstra <peterz@...radead.org>
>     Cc: Robert Richter <robert.richter@...ium.com>
>     Cc: William Cohen <wcohen@...hat.com>
>     Cc: linux-arm-kernel@...ts.infradead.org
>     Link: http://lkml.kernel.org/r/20180307110803.32418-1-ganapatrao.kulkarni@cavium.com
>     [ Fixup wrt recent patchset by John Garry ]
>     Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
>
> diff --git a/tools/perf/pmu-events/arch/arm64/mapfile.csv b/tools/perf/pmu-events/arch/arm64/mapfile.csv
> index 8f11aeb003a9..f03e26ecb658 100644
> --- a/tools/perf/pmu-events/arch/arm64/mapfile.csv
> +++ b/tools/perf/pmu-events/arch/arm64/mapfile.csv
> @@ -14,4 +14,5 @@
>  #Family-model,Version,Filename,EventType
>  0x00000000410fd03[[:xdigit:]],v1,arm/cortex-a53,core
>  0x00000000420f5160,v1,cavium/thunderx2,core
> +0x00000000430f0af0,v1,cavium/thunderx2,core
>  0x00000000480fd010,v1,hisilicon/hip08,core

thanks for help Arnaldo!

thanks
ganapat