linux-kernel - Re: [PATCH 0/2] mtd: use put_device() if device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3975609.gPYExXdWMR@blindfold>
Date:   Sun, 11 Mar 2018 20:35:12 +0100
From:   Richard Weinberger <richard@....at>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     dwmw2@...radead.org, computersforpeace@...il.com,
        boris.brezillon@...e-electrons.com, marek.vasut@...il.com,
        cyrille.pitchen@...ev4u.fr, dedekind1@...il.com,
        linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org
Subject: Re: [PATCH 0/2] mtd: use put_device() if device_register fail

Am Freitag, 9. März 2018, 11:50:47 CET schrieb Arvind Yadav:
> if device_register() returned an error! Always use put_device()
> to give up the reference initialized.
> 
> Arvind Yadav (2):
>   [PATCH 1/2] mtd: use put_device() if device_register fail
>   [PATCH 2/2] mtd: ubi: use put_device() if device_register fail

Uhh, this is not obvious. Does device_register() really always return with a 
reference held in all (error) cases?

Thanks,
//richard