linux-kernel - Plan to move cdc:ad7746 driver out of staging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALfa3vGh4Ni36+ptCdnd0+mxPWDs8OQKe7-egpttgYBpuDTeqA@mail.gmail.com>
Date:   Mon, 12 Mar 2018 16:25:52 -0300
From:   Hernán Gonzalez <hernan@...guardiasur.com.ar>
To:     lars@...afoo.de, Michael.Hennerich@...log.com, jic23@...nel.org,
        knaack.h@....de, pmeerw@...erw.net, gregkh@...uxfoundation.org,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org,
        Daniel Baluta <daniel.baluta@...il.com>
Subject: Plan to move cdc:ad7746 driver out of staging

Hi,

This is my plan for moving out the ad7746 driver out of staging. I
have some specific questions that would be really helpful if someone
can point me in the right direction to go.

1. Pick up on David's clean-up patch. Finish cleaning CHECKs from
checkpatch.pl if possible.

2. Reorder includes alphabetically.

3. Reorder some variable declarations in an inverse-pyramid scheme.

4. Fix sysfs attrs naming to comply with the ABI, e.g.:
in_capacitance0_calibbias_calibration -> in_capacitance0_calibbias

5. Add documentation to the {cap,vt}_filter_rate tables and to the
processed info read. There are some magic numbers out there, I will
read the datasheet and explain the math that I consider appropiate.

6. There are a few too many defines that are not used at all but they
do follow the datasheet. I don't know if there are plans to keep
adding functionalities to this driver or if I should just remove them.

8. EXCLVL is duplicated. There's a simple macro in ad7746.c and some
defines in ad7746.h. The latter are not used anywhere in the code.
Remove them.

7. Move the struct ad7746_platform_data to include/linux/iio.

As mentioned in earlier mails, I will avoid adding new features as I
have no access to the hardware and, therefore, could not test it.

I guess that'd be all. If I'm missing something I would be really
grateful if you can let me know or give me some pointers where to look
at.

Cheers,

Hernán