linux-kernel - Re: [PATCH] platform/x86: dell_smbios: Resolve dependency error on ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180312202939.GB88572@localhost.localdomain>
Date:   Mon, 12 Mar 2018 13:29:39 -0700
From:   Darren Hart <dvhart@...radead.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Platform Driver <platform-driver-x86@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mario Limonciello <mario.limonciello@...l.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] platform/x86: dell_smbios: Resolve dependency error on
 ACPI_WMI

On Mon, Mar 12, 2018 at 11:23:20AM +0200, Andy Shevchenko wrote:
> On Sun, Mar 11, 2018 at 2:28 AM, Darren Hart <dvhart@...radead.org> wrote:
> > Similarly to DCDBAS for DELL_SMBIOS_SMM, if DELL_SMBIOS_WMI is enabled,
> > DELL_SMBIOS becomes dependent on ACPI_WMI. Update the depends line to
> > prevent a configuration where DELL_SMBIOS=y and either backend
> > dependency =m. Update the comment accordingly.
> 
> > +# The DELL_SMBIOS driver depends on ACPI_WMI and/or DCDBAS if those
> > +# backends are selected. The "depends" line prevents a configuration
> > +# where DELL_SMBIOS=y while either of those dependencies =m.
> >  #
> >  config DELL_SMBIOS
> >         tristate "Dell SMBIOS driver"
> > -       depends on DCDBAS || DCDBAS=n
> > +       depends on (DCDBAS || DCDBAS=n) && (ACPI_WMI || ACPI_WMI=n)
> 
> A nit: Perhaps separate depends on line for those two?

Agreed, resending v2, will run through testing, and send to Linus by EOD
tomorrow.

-- 
Darren Hart
VMware Open Source Technology Center