| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <DM5PR12MB1211B9CFBCC532003F5FEDAA89D30@DM5PR12MB1211.namprd12.prod.outlook.com>
Date: Mon, 12 Mar 2018 23:06:23 +0000
From: "Li, Roman" <Roman.Li@....com>
To: "Grodzovsky, Andrey" <Andrey.Grodzovsky@....com>,
David Binderman <dcb314@...mail.com>,
"Deucher, Alexander" <Alexander.Deucher@....com>,
"Koenig, Christian" <Christian.Koenig@....com>,
"Zhou, David(ChunMing)" <David1.Zhou@....com>,
"airlied@...ux.ie" <airlied@...ux.ie>,
"amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"Wentland, Harry" <Harry.Wentland@....com>
Subject: RE:
linux-4.16-rc5/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c:1723]:
(warning) Possible null pointer dereference: pipe_ctx
There is a check just before for-loop that should ensure pipe_ctx is not null:
/* Only supports single display */
if (context->stream_count != 1)
return false;
To remove the subject warning - we can rather add an assert:
assert(pipe_ctx);
Thanks,
Roman
-----Original Message-----
From: Grodzovsky, Andrey
Sent: Monday, March 12, 2018 6:23 PM
To: David Binderman <dcb314@...mail.com>; Deucher, Alexander <Alexander.Deucher@....com>; Koenig, Christian <Christian.Koenig@....com>; Zhou, David(ChunMing) <David1.Zhou@....com>; airlied@...ux.ie; amd-gfx@...ts.freedesktop.org; dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org; Wentland, Harry <Harry.Wentland@....com>; Li, Roman <Roman.Li@....com>
Subject: Re: linux-4.16-rc5/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c:1723]: (warning) Possible null pointer dereference: pipe_ctx
On 03/12/2018 06:22 AM, David Binderman wrote:
> hello there,
>
> Source code is
>
>
> for (i = 0; i < dc->res_pool->pipe_count; i++) {
> if (res_ctx->pipe_ctx[i].stream) {
> pipe_ctx = &res_ctx->pipe_ctx[i];
> *pipe_idx = i;
> break;
> }
> }
Indeed something like
if (!pipe_ctx)
return false;
seems the right thing here.
Harry, Roman , your opinion ?
Andrey
>
> /* Only supports eDP */
> if (pipe_ctx->stream->sink->link->connector_signal !=
> SIGNAL_TYPE_EDP)
> return false;
>
> Suggest add some code to deal with the case that the for loop doesn't
> find what it is looking for and so pipe_ctx is NULL.
>
> Regards
>
> David Binderman
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Powered by blists - more mailing lists