linux-kernel - Re: [PATCH v3 1/3] clk: tegra: Mark HCLK, SCLK and EMC as critical

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180312070430.GA23060@ulmo>
Date:   Mon, 12 Mar 2018 08:04:30 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     Dmitry Osipenko <digetx@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Peter De Schrijver <pdeschrijver@...dia.com>,
        Prashant Gaikwad <pgaikwad@...dia.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        linux-clk@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] clk: tegra: Mark HCLK, SCLK and EMC as critical

On Fri, Mar 09, 2018 at 09:33:06AM -0800, Stephen Boyd wrote:
> Quoting Thierry Reding (2018-03-08 06:44:37)
> > On Thu, Mar 01, 2018 at 04:33:29PM +0300, Dmitry Osipenko wrote:
> > > On 15.01.2018 13:56, Dmitry Osipenko wrote:
> > > > On 10.01.2018 16:59, Dmitry Osipenko wrote:
> > > >> Machine dies if HCLK, SCLK or EMC is disabled. Hence mark these clocks
> > > >> as critical.
> > > >>
> > > >> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> > > >> Acked-by: Peter De Schrijver <pdeschrijver@...dia.com>
> > > >> ---
> > > >>
> > > >> Change log:
> > > >> v2:     Fixed accidentally missed marking EMC as critical on Tegra30 and
> > > >>         Tegra124. Switched to a use of common EMC gate definition on Tegra20
> > > >>         and Tegra30.
> > > >>
> > > >> v3:     Dropped marking PLL_P outputs as critical, because seems they are
> > > >>         not so critical. Although, I still haven't got a definitive answer
> > > >>         about what exact HW functions are affected by the fixed-clocks.
> > > >>         Anyway it should be cleaner to correct the actual drivers.
> > > > 
> > > > Stephen / Michael, would it be possible to schedule these patches for 4.16? My
> > > > T20 and T30 devices aren't working without the 'critical clocks' patch. Things
> > > > happen to work with the opensource u-boot, but not with the proprietary
> > > > bootloader. It's probably not a big deal that out-of-tree devices are broken,
> > > > although would be nice to have one problem less.
> > > 
> > > Guys, is there anything I could do to get these patches in linux-next?
> > 
> > I've picked these up into the for-4.17/clk branch in the Tegra tree. I
> > already have that branch for the MBIST patches which are a dependency
> > for the for-4.17/soc branch.
> > 
> > Stephen, Mike, let me know if you have any objections to carrying these
> > in the Tegra tree.
> > 
> 
> Are you going to send us a PR at some point?

Yes, I was going to let the patches cook a little in linux-next and send
a PR by the end of the week. Does that sound okay?

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)