[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180312080402.GE10358@infradead.org>
Date: Mon, 12 Mar 2018 01:04:02 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
"Rafael J. Wysocki" <rjw@...ysocki.net>, linux-pm@...r.kernel.org,
Keith Busch <keith.busch@...el.com>,
Sinan Kaya <okaya@...eaurora.org>,
Lukas Wunner <lukas@...ner.de>,
Frederick Lawler <fred@...dlawl.com>
Subject: Re: [PATCH v2 08/13] PCI/portdrv: Simplify PCIe feature permission
checking
> + * We assume we can manage these PCIe features. Some systems may
> + * reserve these for use by the platform itself, e.g., an ACPI BIOS
> + * may implement its own AER handling and use _OSC to prevent the
> + * OS from interfering.
> + */
> + bridge->use_aer = 1;
> + bridge->use_hotplug = 1;
> + bridge->use_pme = 1;
If we start out with enabled maybe these should be disable_foo flags
instead?
Also please use bool (or a bitfield bool) for true/false values.
Powered by blists - more mailing lists