linux-kernel - Re: [PATCH 1/4] perf/x86/intel: Add Tremont CPU PMU support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180312084906.ny2nfi5rrcnxs2ji@gmail.com>
Date:   Mon, 12 Mar 2018 09:49:06 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     kan.liang@...ux.intel.com
Cc:     peterz@...radead.org, mingo@...hat.com,
        linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        Kan Liang <kan.liang@...el.com>
Subject: Re: [PATCH 1/4] perf/x86/intel: Add Tremont CPU PMU support


* kan.liang@...ux.intel.com <kan.liang@...ux.intel.com> wrote:

> +	/*TODO: test Adaptive PEBS, no extra implementation needed */
> +		/*TODO: test PDIR fixed counter */
> +		/* TODO: OFFCORE_RESPONSE mask updates for 10nm convered IDI */
> +		/*TODO: implement topdown metrics, base metrics interface same as SNC */

Do you ever _read_ the comments you are writing?

NAK for this kind of inconsistent mess, and it's a repeat pattern - you really 
need to submit cleaner patches!

Thanks,

	Ingo