linux-kernel - Re: [PATCHv5 3/5] mfd: motorola-cpcap: Add audio-codec support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180312090838.ubqvlqnqzv6g4cxr@dell>
Date:   Mon, 12 Mar 2018 09:08:38 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Sebastian Reichel <sebastian.reichel@...labora.co.uk>
Cc:     Tony Lindgren <tony@...mide.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...labora.com
Subject: Re: [PATCHv5 3/5] mfd: motorola-cpcap: Add audio-codec support

On Fri, 09 Mar 2018, Sebastian Reichel wrote:

> Hi,
> 
> On Thu, Mar 08, 2018 at 09:07:36AM -0800, Tony Lindgren wrote:
> > * Sebastian Reichel <sebastian.reichel@...labora.co.uk> [180308 09:47]:
> > > Hi Lee,
> > > 
> > > On Wed, Mar 07, 2018 at 04:32:11PM +0000, Lee Jones wrote:
> > > > On Fri, 23 Feb 2018, Sebastian Reichel wrote:
> > > > > +static const struct mfd_cell cpcap_mfd_devices[] = {
> > > 
> > > [...]
> > > 
> > > > > +	}, {
> > > > > +		.name          = "cpcap-led",
> > > > > +		.id            = 4,
> > > > > +		.of_compatible = "motorola,cpcap-led-cp",
> > > > > +	}, {
> > > > > +		.name          = "cpcap-codec",
> > > > > +	}
> > > > > +};
> > > > 
> > > > With none of the entries containing platform_data /me wonders why you
> > > > can't still use devm_of_platform_populate()?
> > > 
> > > Because devm_of_platform_populate works with compatible properties and
> > > cpcap-codec does not have one after I removed it for Mark.
> > 
> > How about keep devm_of_platform_populate() for the ones that
> > already have compatible. Then add a table entry for cpcap-codec
> > only and call devm_mfd_add_devices()?
> 
> This should work. I think it makes sense to wait for Rob Herring's
> feedback on the binding. My understanding is, that he has the last
> word on binding questions and I would like to avoid changing this
> back and forth.

I've been avoiding mix-and-matching mfd_*() and of_platform_*() APIs,
else it gets too confusing for new developers.

*If* you make the switch to mfd_*() APIs (not preferable), then I
would like to see of_platform_*() removed.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog