linux-kernel - Re: [PATCH v6 01/12] drivers: base: Unified device connection lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <212ceba2-2f13-0501-c59e-612b72989cb3@redhat.com>
Date:   Mon, 12 Mar 2018 10:19:34 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Guenter Roeck <linux@...ck-us.net>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v6 01/12] drivers: base: Unified device connection lookup

Hi,

On 12-03-18 09:13, Heikki Krogerus wrote:
> On Sun, Mar 11, 2018 at 07:24:18PM +0100, Hans de Goede wrote:
>> Hi all,
>>
>> On 09-03-18 18:53, Greg Kroah-Hartman wrote:
>>> On Fri, Mar 02, 2018 at 11:20:46AM +0100, Hans de Goede wrote:
>>>> From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
>>>>
>>>> Several frameworks - clk, gpio, phy, pmw, etc. - maintain
>>>> lookup tables for describing connections and provide custom
>>>> API for handling them. This introduces a single generic
>>>> lookup table and API for the connections.
>>>>
>>>> The motivation for this commit is centralizing the
>>>> connection lookup, but the goal is to ultimately extract the
>>>> connection descriptions also from firmware by using the
>>>> fwnode_graph_* functions and other mechanisms that are
>>>> available.
>>>>
>>>> Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
>>>> Reviewed-by: Hans de Goede <hdegoede@...hat.com>
>>>> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
>>>> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
>>>
>>> Sorry for the delay, just now reviewing this patch...
>>>
>>> The content is fine (if not scary for the obvious reason of passing
>>> around 'struct device' of different bus types, but ok...), but the api
>>> naming is "rough":
>>
>> Heikki, I think it is best if you answer Greg's remarks. FWIW I'm
>> fine with the changes Greg proposes.
> 
> Me too.
> 
>> I currently have significantly less bandwidth for this due to
>> personal circumstances, so if a new version of this patch-set
>> is necessary it would be great if you (Heikki) can do a v7.
> 
> Sure thing. I'll prepare the v7.

Great, thank you. Don't forget to squash in the 2 fixes from
fengguang.wu@...el.com .

Regards,

Hans