linux-kernel - Re: [PATCH] rbd: Remove VLA stack usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOi1vP-TrD9xp4ottwSUEx=h_-uLOYs5BuEMAgSJrK2gmdZoDg@mail.gmail.com>
Date:   Mon, 12 Mar 2018 10:57:08 +0100
From:   Ilya Dryomov <idryomov@...il.com>
To:     "Tobin C. Harding" <me@...in.cc>
Cc:     Eric Biggers <ebiggers3@...il.com>, Sage Weil <sage@...hat.com>,
        Alex Elder <elder@...nel.org>,
        Ceph Development <ceph-devel@...r.kernel.org>,
        linux-kernel@...r.kernel.org, kernel-hardening@...ts.openwall.com,
        Tycho Andersen <tycho@...ho.ws>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] rbd: Remove VLA stack usage

On Mon, Mar 12, 2018 at 6:06 AM, Tobin C. Harding <me@...in.cc> wrote:
> On Sun, Mar 11, 2018 at 10:02:04PM -0700, Eric Biggers wrote:
>> On Mon, Mar 12, 2018 at 03:49:40PM +1100, Tobin C. Harding wrote:
>> > The kernel would like to have all stack VLA usage removed[1].
>>
>> Can you please stop writing this?  The Linux kernel isn't sentient; it doesn't
>> "like" anything.  You need to explain why *you* (and other people) believe these
>> changes should be made.
>
> No worries, will re-spin with better description.

I'd prefer a single patch covering both functions.

Also, as these are char arrays, use sizeof instead of ARRAY_SIZE.

Thanks,

                Ilya