linux-kernel - Re: Bug: Microblaze stopped booting after 0fa1c579349fdd90173381712ad78aa99c09d38b

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <242c2823-258b-d3bb-cd0a-e4eee6b979c6@monstr.eu>
Date:   Mon, 12 Mar 2018 11:21:44 +0100
From:   Michal Simek <monstr@...str.eu>
To:     "Alvaro G. M." <alvaro.gamez@...ent.com>,
        Rob Herring <robh@...nel.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: Bug: Microblaze stopped booting after
 0fa1c579349fdd90173381712ad78aa99c09d38b

On 12.3.2018 08:52, Alvaro G. M. wrote:
> On Fri, Mar 09, 2018 at 01:05:11PM -0600, Rob Herring wrote:
>> On Fri, Mar 9, 2018 at 6:51 AM, Alvaro G. M. <alvaro.gamez@...ent.com> wrote:
>>> Hi,
>>>
>>> I've found via git bisect that 0fa1c579349fdd90173381712ad78aa99c09d38b
>>> makes microblaze unbootable.
>>>
>>> I'm sorry I can't provide any console output, as nothing appears at all,
>>> even when setting earlyprintk (or at least I wasn't able to get anything
>>> back!).
>>
>> Ah, looks like microblaze doesn't set CONFIG_NO_BOOTMEM and so
>> memblock_virt_alloc() doesn't work for CONFIG_HAVE_MEMBLOCK &&
>> !CONFIG_NO_BOOTMEM. AFAICT, microblaze doesn't really need bootmem and
>> it can be removed, but I'm still investigating. Can you try out this
>> branch[1].
>>
>> Rob
>>
>> [1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
>> microblaze-fixes
> 
> Hi, Rob!
> 
> This branch does indeed solve the issue. My microblaze system is now
> booting as it did before, and everything seems normal now. Thanks!
> 
> Tested-by: Alvaro Gamez Machado <alvaro.gamez@...ent.com>
> 

I have tested it and I can also confirm that your two patches are fixing
issue with

809d0e2c: 00240034 26000000 746f6f62 206d656d    4.$....&bootmem
809d0e3c: 6f6c6c61 666f2063 33353220 62203830    alloc of 25308 b
809d0e4c: 73657479 69616620 2164656c 00000000    ytes failed!....
809d0e5c: 00000000 0029003c 06000000 6e72654b    ....<.).....Kern
809d0e6c: 70206c65 63696e61 6e202d20 7320746f    el panic - not s

Can you please update that second commit with reasonable description and
send it out? I will take it via my tree and will send pull request to Linus.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs




Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)