linux-kernel - Re: [PATCH v2] power: supply: da9150-fg: remove VLA usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180312134105.vyuqjluqyght4trd@earth.universe>
Date:   Mon, 12 Mar 2018 14:41:05 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Adam Thomson <Adam.Thomson.Opensource@...semi.com>,
        Support Opensource <support.opensource@...semi.com>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-hardening@...ts.openwall.com,
        Kees Cook <keescook@...omium.org>,
        "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Subject: Re: [PATCH v2] power: supply: da9150-fg: remove VLA usage

Hi,

On Fri, Mar 09, 2018 at 12:27:08PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wvla, remove VLA usage and replace it
> with fixed-length arrays.
> 
> DA9150_QIF_LONG_SIZE (4 bytes) is the biggest size of an attribute which can
> be accessed [1].
> 
> Fixed as part of the directive to remove all VLAs from
> the kernel: https://lkml.org/lkml/2018/3/7/621
> 
> [1] https://marc.info/?l=kernel-hardening&m=152059600524753&w=2
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---

Thanks, queued to power-supply's for-next branch.

-- Sebastian

> Changes in v2:
>  - Use DA9150_QIF_LONG_SIZE instead of DA9150_QIF_BYTE_SIZE as the
>    maximum size for array 'buf'. Thanks to Adam Thomson for the
>    feedback on this.
>  - Update changelog based on Adam's comments.
> 
>  drivers/power/supply/da9150-fg.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/supply/da9150-fg.c b/drivers/power/supply/da9150-fg.c
> index 8b8ce97..7ea2188 100644
> --- a/drivers/power/supply/da9150-fg.c
> +++ b/drivers/power/supply/da9150-fg.c
> @@ -92,7 +92,7 @@ struct da9150_fg {
>  static u32 da9150_fg_read_attr(struct da9150_fg *fg, u8 code, u8 size)
>  
>  {
> -	u8 buf[size];
> +	u8 buf[DA9150_QIF_LONG_SIZE];
>  	u8 read_addr;
>  	u32 res = 0;
>  	int i;
> @@ -111,7 +111,7 @@ static void da9150_fg_write_attr(struct da9150_fg *fg, u8 code, u8 size,
>  				 u32 val)
>  
>  {
> -	u8 buf[size];
> +	u8 buf[DA9150_QIF_LONG_SIZE];
>  	u8 write_addr;
>  	int i;
>  
> -- 
> 2.7.4
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)