linux-kernel - Re: [PATCH] gpio: dwapb: Add support for a bus clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VcxH=UQoc5oMjTMHZvCqmYths5LPTVVzY-ntC+r3ivguQ@mail.gmail.com>
Date:   Mon, 12 Mar 2018 15:58:02 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Phil Edworthy <phil.edworthy@...esas.com>
Cc:     Hoan Tran <hotran@....com>,
        Linus Walleij <linus.walleij@...aro.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Michel Pollet <michel.pollet@...renesas.com>
Subject: Re: [PATCH] gpio: dwapb: Add support for a bus clock

On Fri, Mar 9, 2018 at 12:34 PM, Phil Edworthy
<phil.edworthy@...esas.com> wrote:
> From: Michel Pollet <michel.pollet@...renesas.com>
>
> Enable specified clocks from DTS, if any.
>
> Signed-off-by: Michel Pollet <michel.pollet@...renesas.com>

>  #include <linux/spinlock.h>
>  #include <linux/platform_data/gpio-dwapb.h>
>  #include <linux/slab.h>
> +#include <linux/clk.h>

Keep in order.


> +       clk = devm_clk_get(&pdev->dev, NULL);
> +       if (!IS_ERR(clk) && clk_prepare_enable(clk))
> +               dev_info(&pdev->dev, "no clock source\n");

First of all, it shadows any error from clk_prepare_enable(), second,
it misses the clock name.
Next, I don't see how you managed the clock during PM and / or
->remove() operation.

-- 
With Best Regards,
Andy Shevchenko