[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1520864837.10722.596.camel@linux.intel.com>
Date: Mon, 12 Mar 2018 16:27:17 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Harish Jenny K N <harish_kandiga@...tor.com>,
Avri Altman <Avri.Altman@....com>,
"ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
"adrian.hunter@...el.com" <adrian.hunter@...el.com>,
"shawn.lin@...k-chips.com" <shawn.lin@...k-chips.com>
Cc: "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"Vladimir_Zapolskiy@...tor.com" <Vladimir_Zapolskiy@...tor.com>
Subject: Re: [PATCH v9] mmc: Export host capabilities to debugfs.
On Mon, 2018-03-12 at 16:22 +0200, Andy Shevchenko wrote:
> On Mon, 2018-03-12 at 19:04 +0530, Harish Jenny K N wrote:
> >
> > On Monday 12 March 2018 06:33 PM, Andy Shevchenko wrote:
> > > On Mon, 2018-03-12 at 18:00 +0530, Harish Jenny K N wrote:
> > > > > > > > > + for_each_set_bit(bit, (const unsigned long
> > > > > > > > > *)&caps,
> > > > > > > > > BITS_PER_LONG)
> > > > > > > > > + for_each_set_bit(bit, (const unsigned long
> > > > > > > > > *)&caps2,
> > > > > > > > > BITS_PER_LONG)
> > > > > > > >
> > > > > > > > Explicit casting is not needed anymore in both cases.
> > Sorry for I was not clear that the compilation error is for the
> > following case
> > > u32 caps = host->caps;
This is wrong! I told you that and you seems changed at least in v9.
What are you doing locally?
> > > for_each_set_bit(bit, &caps, ARRAY_SIZE(mmc_host_capabilities))
> >
> Are you sure you have caps defined as unsigned long?
>
> Check your code, the explicit casting should gone. Otherwise you are
> doing something wrong.
See above.
--
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy
Powered by blists - more mailing lists