linux-kernel - Re: [PATCH] net: hns: use put_device() if device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180312.104323.14368638452528082.davem@davemloft.net>
Date:   Mon, 12 Mar 2018 10:43:23 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     arvind.yadav.cs@...il.com
Cc:     yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        linyunsheng@...wei.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: hns: use put_device() if device_register fail

From: Arvind Yadav <arvind.yadav.cs@...il.com>
Date: Fri,  9 Mar 2018 16:11:17 +0530

> if device_register() returned an error! Always use put_device()
> to give up the reference initialized.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

I do not see anything giving cls_dev an initial non-zero reference
count before this device_register() call.

And I have no idea why you use a "!" when saying 'error' you this
commit log message.