[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHC9VhTaHA0v-8=QkEDzTyXFvk1oFHnFj6EbHxGetU+pmr+iPQ@mail.gmail.com>
Date: Mon, 12 Mar 2018 11:01:13 -0400
From: Paul Moore <paul@...l-moore.com>
To: Richard Guy Briggs <rgb@...hat.com>
Cc: Linux-Audit Mailing List <linux-audit@...hat.com>,
LKML <linux-kernel@...r.kernel.org>,
Eric Paris <eparis@...hat.com>,
Steve Grubb <sgrubb@...hat.com>,
Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH ghak21 V2 1/4] audit: make ANOM_LINK obey audit_enabled
and audit_dummy_context
On Mon, Mar 12, 2018 at 2:31 AM, Richard Guy Briggs <rgb@...hat.com> wrote:
> Audit link denied events emit disjointed records when audit is disabled.
> No records should be emitted when audit is disabled.
>
> See: https://github.com/linux-audit/audit-kernel/issues/21
> Signed-off-by: Richard Guy Briggs <rgb@...hat.com>
> ---
> kernel/audit.c | 3 +++
> 1 file changed, 3 insertions(+)
As stated previously, this has already been merged. Ignoring.
> diff --git a/kernel/audit.c b/kernel/audit.c
> index 1a3e75d..7026d69 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -2308,6 +2308,9 @@ void audit_log_link_denied(const char *operation, const struct path *link)
> struct audit_buffer *ab;
> struct audit_names *name;
>
> + if (!audit_enabled || audit_dummy_context())
> + return;
> +
> name = kzalloc(sizeof(*name), GFP_NOFS);
> if (!name)
> return;
> --
> 1.8.3.1
--
paul moore
www.paul-moore.com
Powered by blists - more mailing lists