linux-kernel - Re: [PATCH] echoaudio: remove redundant initialization of pointer 'pipe'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h8tax49kd.wl-tiwai@suse.de>
Date:   Mon, 12 Mar 2018 16:06:58 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Colin King" <colin.king@...onical.com>
Cc:     <alsa-devel@...a-project.org>,
        "Arvind Yadav" <arvind.yadav.cs@...il.com>,
        "Jaroslav Kysela" <perex@...ex.cz>,
        "Takashi Sakamoto" <o-takashi@...amocchi.jp>,
        <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] echoaudio: remove redundant initialization of pointer 'pipe'

On Mon, 12 Mar 2018 16:01:00 +0100,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> The pointer 'pipe' is being initialized with a value that is never
> read and it is re-assigned later, hence the initialization is redundant
> and can be removed. Also remove pointer 'runtime' as it is no longer
> required.
> 
> Cleans up clang warning:
> sound/pci/echoaudio/echoaudio.c:740:20: warning: Value stored to 'pipe'
> during its initialization is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks.


Takashi