linux-kernel - Re: [PATCH] net: llc: drop VLA in llc_sap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180312.111432.849792523664957837.davem@davemloft.net>
Date:   Mon, 12 Mar 2018 11:14:32 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     s.mesoraca16@...il.com
Cc:     linux-kernel@...r.kernel.org, kernel-hardening@...ts.openwall.com,
        netdev@...r.kernel.org, paulmck@...ux.vnet.ibm.com,
        rientjes@...gle.com, elena.reshetova@...el.com,
        ishkamiel@...il.com, keescook@...omium.org
Subject: Re: [PATCH] net: llc: drop VLA in llc_sap_mcast()

From: Salvatore Mesoraca <s.mesoraca16@...il.com>
Date: Sun, 11 Mar 2018 22:12:04 +0100

> Avoid a VLA[1] by using a real constant expression instead of a variable.
> The compiler should be able to optimize the original code and avoid using
> an actual VLA. Anyway this change is useful because it will avoid a false
> positive with -Wvla, it might also help the compiler generating better
> code.
> 
> [1] https://lkml.org/lkml/2018/3/7/621
> 
> Signed-off-by: Salvatore Mesoraca <s.mesoraca16@...il.com>

Applied.