linux-kernel - Re: [PATCH] kbuild: check for pkg-config on make menu/n/g/xconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a06826d9-1607-72c6-2e30-ab56b2306bd8@infradead.org>
Date:   Mon, 12 Mar 2018 10:44:44 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Bjørn Forsman <bjorn.forsman@...il.com>
Cc:     linux-kbuild <linux-kbuild@...r.kernel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kbuild: check for pkg-config on make menu/n/g/xconfig

On 03/11/2018 02:00 PM, Bjørn Forsman wrote:
> On 11 March 2018 at 21:12, Randy Dunlap <rdunlap@...radead.org> wrote:
>> +pkgcfg=`which pkg-config >/dev/null 2>&1`
> 
> Please use "command -v" instead of "which". command -v is in POSIX, so
> the shell will have it for sure (builtin). which is not a builtin, it
> is an external command that may or may not be installed on the system.

Will do. Thanks.

Just waiting to see if there are any other comments...

-- 
~Randy