linux-kernel - Re: [PATCH] mtd: chips: Replace printk() with pr_*() and define pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VfZKrm-K+VJDmFrwxyqVvm9D9CuZV6CVtsNSrw6WWfQRA@mail.gmail.com>
Date:   Tue, 13 Mar 2018 18:28:13 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Arushi Singhal <arushisinghal19971997@...il.com>
Cc:     David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Richard Weinberger <richard@....at>,
        Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        "open list:MEMORY TECHNOLOGY..." <linux-mtd@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: chips: Replace printk() with pr_*() and define pr_fmt()

On Mon, Mar 12, 2018 at 7:02 PM, Arushi Singhal
<arushisinghal19971997@...il.com> wrote:
> Using pr_<loglevel>() is more concise than printk(KERN_<LOGLEVEL>).
> This patch:


> @@ -182,7 +184,7 @@ static void fixup_convert_atmel_pri(struct mtd_info *mtd)

> -       printk(KERN_ERR "atmel Features: %02x\n", atmel_pri.Features);
> +       pr_err("atmel Features: %02x\n", atmel_pri.Features);

Does struct mtd_info include a pointer to struct device? In such case,
why not to use dev_*() macros instead?
(It's a question to the all current pr_*()/printk() calls.

-- 
With Best Regards,
Andy Shevchenko