linux-kernel - Re: [PATCH v2 0/1] Open questions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ba3f53b1-e8bb-4c61-b486-19b9865d6e22@pengutronix.de>
Date:   Tue, 13 Mar 2018 18:48:40 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     "Dr. Philipp Tomsich" <philipp.tomsich@...obroma-systems.com>,
        Jakob Unterwurzacher <jakob.unterwurzacher@...obroma-systems.com>
Cc:     Martin Elshuber <martin.elshuber@...obroma-systems.com>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        linux-can@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/1] Open questions

On 03/13/2018 06:42 PM, Dr. Philipp Tomsich wrote:
> 
>> On 13 Mar 2018, at 18:40, Jakob Unterwurzacher
>> <jakob.unterwurzacher@...obroma-systems.com
>> <mailto:jakob.unterwurzacher@...obroma-systems.com>> wrote:
>>
>> >> +    /* get the urb context */
>> >> +    if (WARN_ON(!context))
>> >> +        return;
>> >
>> > Can this happen?
>>
>> Not unless there is a bug in the code. But we want to get a message
>> before dereferencing a pointer.
> 
> Why not use BUG_ON(!context)?

As this will halt the whole system.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)