linux-kernel - Re: [PATCH net-next] net: fix sysctl_fb_tunnels_only_for_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180313.141540.1209207885849202206.davem@davemloft.net>
Date:   Tue, 13 Mar 2018 14:15:40 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     edumazet@...gle.com, jiri@...lanox.com, daniel@...earbox.net,
        jakub.kicinski@...ronome.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: fix sysctl_fb_tunnels_only_for_init_net
 link error

From: Arnd Bergmann <arnd@...db.de>
Date: Tue, 13 Mar 2018 12:44:53 +0100

> The new variable is only available when CONFIG_SYSCTL is enabled,
> otherwise we get a link error:
> 
> net/ipv4/ip_tunnel.o: In function `ip_tunnel_init_net':
> ip_tunnel.c:(.text+0x278b): undefined reference to `sysctl_fb_tunnels_only_for_init_net'
> net/ipv6/sit.o: In function `sit_init_net':
> sit.c:(.init.text+0x4c): undefined reference to `sysctl_fb_tunnels_only_for_init_net'
> net/ipv6/ip6_tunnel.o: In function `ip6_tnl_init_net':
> ip6_tunnel.c:(.init.text+0x39): undefined reference to `sysctl_fb_tunnels_only_for_init_net'
> 
> This adds an extra condition, keeping the traditional behavior when
> CONFIG_SYSCTL is disabled.
> 
> Fixes: 79134e6ce2c9 ("net: do not create fallback tunnels for non-default namespaces")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thank you.