linux-kernel - RE: [PATCH v3 1/7] x86/hyper-v: move hyperv.h out of uapi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Mar 2018 22:46:10 +0000
From:   "Michael Kelley (EOSG)" <Michael.H.Kelley@...rosoft.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>
CC:     "x86@...nel.org" <x86@...nel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Mohammed Gamal <mmorsy@...hat.com>,
        Cathy Avery <cavery@...hat.com>, Bandan Das <bsd@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 1/7] x86/hyper-v: move hyperv.h out of uapi

> -----Original Message-----
> From: Vitaly Kuznetsov <vkuznets@...hat.com>
> Sent: Friday, March 9, 2018 6:03 AM
> To: kvm@...r.kernel.org
> Cc: x86@...nel.org; Paolo Bonzini <pbonzini@...hat.com>; Radim Krčmář
> <rkrcmar@...hat.com>; KY Srinivasan <kys@...rosoft.com>; Haiyang Zhang
> <haiyangz@...rosoft.com>; Stephen Hemminger <sthemmin@...rosoft.com>; Michael
> Kelley (EOSG) <Michael.H.Kelley@...rosoft.com>; Mohammed Gamal
> <mmorsy@...hat.com>; Cathy Avery <cavery@...hat.com>; Bandan Das <bsd@...hat.com>;
> linux-kernel@...r.kernel.org
> Subject: [PATCH v3 1/7] x86/hyper-v: move hyperv.h out of uapi
> 
> hyperv.h is not part of uapi, there are no (known) users outside of kernel.
> We are making changes to this file to match current Hyper-V TLFS and we
> don't want to maintain backwards compatibility.
> 
> Move the file renaming to hyperv-tlfs.h to avoid confusing it with
> mshyperv.h. In future, all definitions from TLFS should go to it and
> all kernel objects should go to mshyperv.h or include/linux/hyperv.h.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
> ---

[snip]

> diff --git a/drivers/hv/connection.c b/drivers/hv/connection.c
> index 447371f4de56..72855182b191 100644
> --- a/drivers/hv/connection.c
> +++ b/drivers/hv/connection.c
> @@ -31,7 +31,6 @@
>  #include <linux/vmalloc.h>
>  #include <linux/hyperv.h>
>  #include <linux/export.h>
> -#include <asm/hyperv.h>

This #include should remain and be changed to asm/hyperv-tlfs.h.  This
file uses the hypercall status values HV_STATUS_*.

>  #include <asm/mshyperv.h>
> 
>  #include "hyperv_vmbus.h"
> diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> index fe96aab9e794..45f3694bbb76 100644
> --- a/drivers/hv/hv.c
> +++ b/drivers/hv/hv.c
> @@ -29,7 +29,6 @@
>  #include <linux/version.h>
>  #include <linux/interrupt.h>
>  #include <linux/clockchips.h>
> -#include <asm/hyperv.h>

This #include should remain and be changed to asm/hyperv-tlfs.h.  This
file uses HV_MESSAGE_* values.

>  #include <asm/mshyperv.h>
>  #include "hyperv_vmbus.h"
> 
> diff --git a/drivers/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h
> index 22300ec7b556..500f805a6ef2 100644
> --- a/drivers/hv/hyperv_vmbus.h
> +++ b/drivers/hv/hyperv_vmbus.h
> @@ -27,6 +27,7 @@
> 
>  #include <linux/list.h>
>  #include <asm/sync_bitops.h>
> +#include <asm/hyperv-tlfs.h>
>  #include <linux/atomic.h>
>  #include <linux/hyperv.h>
>  #include <linux/interrupt.h>
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index bc65c4d79c1f..b10fe26c4891 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -36,7 +36,6 @@
>  #include <linux/cpu.h>
>  #include <linux/sched/task_stack.h>
> 
> -#include <asm/hyperv.h>

This #include should remain and be changed to asm/hyperv-tlfs.h.  This
file uses HVMSG_* values.

>  #include <asm/mshyperv.h>
>  #include <linux/notifier.h>
>  #include <linux/ptrace.h>

Michael