linux-kernel - Re: [PATCH] proc: reject "." and ".." as filenames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180313072029.GA3176@avx2>
Date:   Tue, 13 Mar 2018 10:20:29 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org, eric.dumazet@...il.com,
        xiyou.wangcong@...il.com, fw@...len.de
Subject: Re: [PATCH] proc: reject "." and ".." as filenames

On Mon, Mar 12, 2018 at 04:00:18PM -0700, Andrew Morton wrote:
> -	if (qstr.len == 1 && fn[0] == '.') {
> -		WARN(1, "name '.'\n");
> +	if (WARN(qstr.len == 1 && fn[0] == '.', "name '.'\n"))
>  		return NULL;
> -	}

Oh, I hate this style of WARN.
For one thing it overlaps with comma operator.