linux-kernel - Re: [pci PATCH v5 3/4] ena: Migrate over to unmanaged SR-IOV support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1520928772.28745.53.camel@infradead.org>
Date:   Tue, 13 Mar 2018 08:12:52 +0000
From:   David Woodhouse <dwmw2@...radead.org>
To:     Alexander Duyck <alexander.duyck@...il.com>, bhelgaas@...gle.com,
        alexander.h.duyck@...el.com, linux-pci@...r.kernel.org
Cc:     virtio-dev@...ts.oasis-open.org, kvm@...r.kernel.org,
        netdev@...r.kernel.org, dan.daly@...el.com,
        linux-kernel@...r.kernel.org, linux-nvme@...ts.infradead.org,
        keith.busch@...el.com, netanel@...zon.com, mheyne@...zon.de,
        liang-min.wang@...el.com, mark.d.rustad@...el.com, hch@....de
Subject: Re: [pci PATCH v5 3/4] ena: Migrate over to unmanaged SR-IOV
 support

On Mon, 2018-03-12 at 10:23 -0700, Alexander Duyck wrote:
> 
> -       .sriov_configure = ena_sriov_configure,
> +#ifdef CONFIG_PCI_IOV
> +       .sriov_configure = pci_sriov_configure_simple,
> +#endif
>  };

I'd like to see that ifdef go away, as discussed. I agree that just
#define pci_sriov_configure_simple NULL
should suffice. As Christoph points out, it's not going to compile if
people try to just invoke it directly.

I'd also *really* like to see a way to enable this for PFs which don't
have (and don't need) a driver. We seem to have lost that along the
way.

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5213 bytes)