linux-kernel - Re: hwmon/sch5627: Use common error handling code in sch5627

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17810b74-7b72-074e-5fef-b614fcfed738@users.sourceforge.net>
Date:   Tue, 13 Mar 2018 09:25:51 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Hans de Goede <hdegoede@...hat.com>, linux-hwmon@...r.kernel.org
Cc:     Günter Röck <linux@...ck-us.net>,
        Jean Delvare <jdelvare@...e.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: hwmon/sch5627: Use common error handling code in sch5627_probe()

>> Adjust jump targets so that a bit of exception handling can be better
>> reused at the end of this function.
…
> goto-s going to a label calling another goto is completely unreadable.

I got an other software development view.


> I really do not see any reason for the proposed changes,

I suggest to look once more.


> they may remove a small amount of code duplication,

This was my software design goal in this case.


> but at a hugh cost wrt readability.

I proposed a different trade-off here.

Regards,
Markus