linux-kernel - Re: linux-next on thinkpad x60: full battery is indicated as battery error in mate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Mar 2018 10:14:43 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Ognjen Galić <smclt30p@...il.com>,
        Pavel Machek <pavel@....cz>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        kernel list <linux-kernel@...r.kernel.org>,
        ACPI mailing list <linux-acpi@...r.kernel.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Sebastian Reichel <sre@...nel.org>
Subject: Re: linux-next on thinkpad x60: full battery is indicated as battery
 error in mate

On Tue, Mar 13, 2018 at 1:51 AM, Ognjen Galić <smclt30p@...il.com> wrote:
> On Tue, Mar 13, 2018 at 12:18:47AM +0100, Pavel Machek wrote:
>> Hi!
>>
>> > >> > >> Fully charged
>> > >> > >> battery shows as empty battery with red "x" in Mate desktop. After
>> > >> > >> reboot to recent mainline problem goes away. Tooltip says "battery
>> > >> > >> waiting to charge".
>> > >> > >>
>> > >>
>> > >> For the MATE bug see:
>> > >> https://github.com/mate-desktop/mate-power-manager/pull/251
>> > >>
>> > >> The problem is in the new composite battery system in UPower, it
>> > >> "merges" two external batteries into a single one for reporting. That
>> > >> battery does not understand "Not Charging" inside the MATE Power
>> > >> Manager. The above patch fixes that in MATE.
>> > >
>> > > Ok, so problem is 91eea70e5e5ce12eb1c7cd922e561fab43e201bd.
>> > >
>> > > And now, I see that MATE should be improved.
>> > >
>> > > But what I also see is that kernel is changing its interface in a way
>> > > that (while making sense) breaks existing application. And we don't
>> > > break existing applications.
>> > >
>> > > [Now... maybe if the fix for the application is available for long
>> > > long time and noone is really looking and everyone already has new
>> > > application version, maybe ... But pull request for MATE is 9 days
>> > > old, and not even merged. So there is no way this is suitable for
>> > > 4.17.]
>> >
>> > Right.
>> >
>> > This basically means that we will have to defer the battery changes
>> > until user space is ready and not just upstream, but also in distro
>> > packages.
>>
>> Yes please.
>>
>> Note that only 91eea70e5e5ce12eb1c7cd922e561fab43e201bd should break
>> anything, the others should be safe AFAICT?
>>
>>                                                               Pavel
>>
>
> Actually there is a bug in UPower itself, and that reflects the status
> icon being broken in almost all desktop environments. I will work on
> fixing UPower in the following days. Disregard my previous comment.

I have reverted commit 91eea70e5e5ce12e for the time being.

Of course, it can be applied again after all of the bus triggered by
it have been fixed and the fixes have gone to users.