linux-kernel - Re: [PATCH 4.4 24/36] netlink: ensure to loop over all netns in genlmsg_multicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1520899459.23626.87.camel@codethink.co.uk>
Date:   Tue, 13 Mar 2018 00:04:19 +0000
From:   Ben Hutchings <ben.hutchings@...ethink.co.uk>
To:     Nicolas Dichtel <nicolas.dichtel@...nd.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     stable@...r.kernel.org, Johannes Berg <johannes.berg@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4.4 24/36] netlink: ensure to loop over all netns in
 genlmsg_multicast_allns()

On Fri, 2018-03-09 at 16:18 -0800, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> 
> 
> [ Upstream commit cb9f7a9a5c96a773bbc9c70660dc600cfff82f82 ]
[...] 
> -	return nlmsg_multicast(prev->genl_sock, skb, portid, group, flags);
> +	err = nlmsg_multicast(prev->genl_sock, skb, portid, group, flags);
> +	if (!err)
> +		delivered = true;
> +	else if (err != -ESRCH)
> +		goto error;

This call to nlmsg_multicast() consumes skb rather than a clone, so we
must not free it again here.

Ben.

> +	return delivered ? 0 : -ESRCH;
>   error:
>  	kfree_skb(skb);
>  	return err;
> 
> 
> 
-- 
Ben Hutchings
Software Developer, Codethink Ltd.