linux-kernel - Re: [PATCH] mailbox: tegra: relax TEGRA_HSP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180313133654.GA5374@ulmo>
Date:   Tue, 13 Mar 2018 14:36:58 +0100
From:   Thierry Reding <treding@...dia.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     Jassi Brar <jassisinghbrar@...il.com>,
        Mikko Perttunen <mperttunen@...dia.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mailbox: tegra: relax TEGRA_HSP_MBOX Kconfig dependencies

On Tue, Mar 13, 2018 at 01:11:43PM +0100, Arnd Bergmann wrote:
> With the addition of the ARCH_TEGRA_194_SOC driver, we get a new Kconfig warning:
> 
> warning: (ARCH_TEGRA_186_SOC && ARCH_TEGRA_194_SOC) selects TEGRA_HSP_MBOX which has unmet direct dependencies (MAILBOX && ARCH_TEGRA_186_SOC)
> 
> It looks like the dependency is a bit too strict here, allowing the driver to
> be built for any Tegra chip avoids the problem.
> 
> Fixes: 6f9ed07fde03 ("soc/tegra: Add Tegra194 SoC configuration option")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/mailbox/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

The HSP does not exist on any chip prior to Tegra186, which is what the
dependency reflects. However, I agree that there is little point for an
exact list of per-chip dependencies. We don't really support non-multi-
platform kernels anymore, or at least they don't get any testing, so
relaxing the dependency is fine with me.

Acked-by: Thierry Reding <treding@...dia.com>

Thanks for fixing this,
Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)