linux-kernel - Re: [PATCH v2 1/2] mfd: rk808: Change DEV_OFF to DEV_OFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <eb547d50-0dfb-765a-7f1c-8dd367ea0fde@phytec.de>
Date:   Tue, 13 Mar 2018 15:14:36 +0100
From:   Daniel Schultz <d.schultz@...tec.de>
To:     Joseph Chen <chenjh@...k-chips.com>,
        Lee Jones <lee.jones@...aro.org>
Cc:     zyw@...k-chips.com, zhangqing@...k-chips.com,
        linux-kernel@...r.kernel.org, w.egorov@...tec.de
Subject: Re: [PATCH v2 1/2] mfd: rk808: Change DEV_OFF to DEV_OFF_RST for
 rk818 shutdown

Hi,

On 03/13/2018 03:44 AM, Joseph Chen wrote:
> Hi, Lee and Daniel：
> 
>      I am really sorry for reply so late,  I don't realize that Daniel's 
> emails ended up in my junk mail file.
> 
> 
> 在 2018/3/12 22:09, Lee Jones 写道:
>> Rockchip guys,
>>
>> I'd really appreciate your input on these two patches please.
>>
>> Please provide Reviewed-by/Tested-by tags.
>>
>> On Wed, 07 Mar 2018, Daniel Schultz wrote:
>>> After running "poweroff", the PMIC restarts the SoC instead of shutting
>>> it down.
>>>
>>> It seems like the description for those two register bits is swapped.
>>> After changing from DEV_OFF to DEV_OFF_RST, the system can poweroff
>>> correctly.
>>>
>>> Signed-off-by: Daniel Schultz<d.schultz@...tec.de>
>>> ---
>>> Changes:
>>> 	v2: Re-submit with recipients from Rockchip.
>>>
>>>   drivers/mfd/rk808.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
>>> index 216fbf6..d138721 100644
>>> --- a/drivers/mfd/rk808.c
>>> +++ b/drivers/mfd/rk808.c
>>> @@ -418,7 +418,7 @@ static void rk818_device_shutdown(void)
>>>   
>>>   	ret = regmap_update_bits(rk808->regmap,
>>>   				 RK818_DEVCTRL_REG,
>>> -				 DEV_OFF, DEV_OFF);
>>> +				 DEV_OFF_RST, DEV_OFF_RST);
>>>   	if (ret)
>>>   		dev_err(&rk808_i2c_client->dev, "power off error!\n");
>>>   }
> 
> I think there maybe something wrong makes your machine restart after 
> "poweroff".
>      (1) Is your machine attaching charger when you run "poweroff"? 
> RK818 is hardware designed to auto power on when it detects voltage on 
> input pins(8,9);

That's the point! Both pins are driven high... thank you!

We will check how we can handle this on our hardware. For now, I will 
recall this patch.

-- 
Mit freundlichen Grüßen,
With best regards,
   Daniel Schultz

>      (2) If restart, you can dump ON_SOURCE(address: 0xAE) and 
> OFF_SOURCE(address: 0xAF) in rk808.c probe() to know  last power off 
> reason and currently power on reason;
> 
> -- 
> Best Regards
> ----------------------------------------------------------------------------
> 陈健洪 (Joseph Chen)
> E-mail：chenjh@...k-chips.com
> 福州瑞芯微电子股份有限公司
> Fuzhou Rockchip Electronics Co.Ltd
> 福建省福州市铜盘路软件大道89号软件园A区21号楼 (350003)
> No. 21 Building, A District, No.89,software Boulevard Fuzhou,Fujian,PRC
> TEL：0591-83991906/07-8573
>