linux-kernel - Re: [PATCH 18/31] perf vendor events arm64: Add armv8-recommended.json

Open Source and information security mailing list archives

Date:   Tue, 13 Mar 2018 15:27:05 +0000
From:   John Garry <john.garry@...wei.com>
To:     Ingo Molnar <mingo@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>
CC:     Shaokun Zhang <zhangshaokun@...ilicon.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        "Alexander Shishkin" <alexander.shishkin@...ux.intel.com>,
        Will Deacon <will.deacon@....com>,
        <linux-kernel@...r.kernel.org>, <linuxarm@...wei.com>,
        <linux-perf-users@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ganapatrao Kulkarni <ganapatrao.kulkarni@...ium.com>,
        Namhyung Kim <namhyung@...nel.org>,
        William Cohen <wcohen@...hat.com>,
        Jiri Olsa <jolsa@...hat.com>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 18/31] perf vendor events arm64: Add
 armv8-recommended.json

On 13/03/2018 15:08, Ingo Molnar wrote:
>
> * John Garry <john.garry@...wei.com> wrote:
>
>> On 13/03/2018 14:26, Ingo Molnar wrote:
>>>
>>> * Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
>>>
>>>> From: John Garry <john.garry@...wei.com>
>>>>
>>>> Add JSON for ARMv8 IMPLEMENTATION DEFINED recommended events.
>>>>
>>>> The JSON is copied from ARMv8 architecture reference manual, available
>>>> here:
>>>>
>>>> 	https://static.docs.arm.com/ddi0487/ca/DDI0487C_a_armv8_arm.pdf
>>>>
>>>> Signed-off-by: Shaokun Zhang <zhangshaokun@...ilicon.com>

Originally-from: Shaokun Zhang <zhangshaokun@...ilicon.com>

>>>> Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
>>>> Cc: Andi Kleen <ak@...ux.intel.com>
>>>> Cc: Ganapatrao Kulkarni <ganapatrao.kulkarni@...ium.com>
>>>> Cc: Jiri Olsa <jolsa@...hat.com>
>>>> Cc: Namhyung Kim <namhyung@...nel.org>
>>>> Cc: Peter Zijlstra <peterz@...radead.org>
>>>> Cc: Shaokun Zhang <zhangshaokun@...ilicon.com>
>>>> Cc: Will Deacon <will.deacon@....com>
>>>> Cc: William Cohen <wcohen@...hat.com>
>>>> Cc: linux-arm-kernel@...ts.infradead.org
>>>> Cc: linuxarm@...wei.com
>>>> Link: http://lkml.kernel.org/r/1520506716-197429-9-git-send-email-john.garry@huawei.com
>>>> Signed-off-by: John Garry <john.garry@...wei.com>
>>>> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
>>>
>>> That's not a valid SOB chain, author != first-Signed-off-by.
>>>
>>
>> Right, so my SOB can go first.
>>
>> Let me know how to help remedy.
>
> Well, it depends on what role Shaokun Zhang had in the creation of the patch: if
> he co-authored the patch and you finished it then you can add him as:
>
>   Originally-from: Shaokun Zhang <zhangshaokun@...ilicon.com>
>
> or if he tested/reviewed the patch then his entry should be Reviewed-by/Acked-by
> or Tested-by.
>

Hi Ingo, Arnaldo,

I think it would be fair to say the former, that is: "he co-authored the 
patch and you finished it".

Thanks,
John

> Thanks,
>
> 	Ingo
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives