linux-kernel - Re: [PATCH v3 02/10] video: add support of MIPI DSI interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Mar 2018 09:30:37 -0600
From:   Simon Glass <sjg@...omium.org>
To:     yannick fertre <yannick.fertre@...com>
Cc:     Vikas Manocha <vikas.manocha@...com>,
        Tom Rini <trini@...sulko.com>,
        Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        Philippe Cornu <philippe.cornu@...com>,
        Patrice Chotard <patrice.chotard@...com>,
        Patrick DELAUNAY <patrick.delaunay@...com>,
        Christophe KERELLO <christophe.kerello@...com>,
        Archit Taneja <architt@...eaurora.org>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        David Airlie <airlied@...ux.ie>,
        Brian Norris <briannorris@...omium.org>,
        Bhumika Goyal <bhumirks@...il.com>,
        Gustavo Padovan <gustavo@...ovan.org>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Sean Paul <seanpaul@...omium.org>,
        Albert Aribaud <albert.u.boot@...baud.net>,
        Anatolij Gustschin <agust@...x.de>,
        Thierry Reding <thierry.reding@...il.com>,
        U-Boot Mailing List <u-boot@...ts.denx.de>,
        dri-devel@...ts.freedesktop.org, lk <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 02/10] video: add support of MIPI DSI interface

Hi,

On 13 March 2018 at 07:50, yannick fertre <yannick.fertre@...com> wrote:
>
> Mipi_display.c contains a set of dsi helpers.
> This file is a copy of file drm_mipi_dsi.c (linux kernel).
>
> Signed-off-by: yannick fertre <yannick.fertre@...com>
> ---
>  drivers/video/Kconfig        |   7 +
>  drivers/video/Makefile       |   1 +
>  drivers/video/mipi_display.c | 807 +++++++++++++++++++++++++++++++++++++++++++
>  include/mipi_display.h       | 257 +++++++++++++-

Please add function comments for the functions in this file,
explaining args and what the functions do.

Shouldn't DSI be its own uclass? We normally separate drivers for
different peripherals in U-Boot.

>  4 files changed, 1071 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/video/mipi_display.c
>
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 2fc0def..1981298 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -75,6 +75,13 @@ config VIDEO_ANSI
>           Enable ANSI escape sequence decoding for a more fully functional
>           console.
>
> +config VIDEO_MIPI_DSI
> +       bool "Support MIPI DSI interface"
> +       depends on DM_VIDEO
> +       default y if DM_VIDEO
> +       help
> +         Support MIPI DSI interface for driving a MIPI compatible LCD panel.

Please expand out what MIPI stands for and what it is, same with DSI.