linux-kernel - Re: [PATCH 2/2] x86/mm: remove pointless checks in vmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1803142024540.1946@nanos.tec.linutronix.de>
Date:   Wed, 14 Mar 2018 20:27:10 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Toshi Kani <toshi.kani@....com>
cc:     mingo@...hat.com, hpa@...or.com, bp@...en8.de, luto@...nel.org,
        gratian.crisan@...com, x86@...nel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] x86/mm: remove pointless checks in vmalloc_fault

On Tue, 13 Mar 2018, Toshi Kani wrote:

> vmalloc_fault() sets user's pgd or p4d from the kernel page table.
> Once it's set, all tables underneath are identical. There is no point
> of following the same page table with two separate pointers and makes
> sure they see the same with BUG().
> 
> Remove the pointless checks in vmalloc_fault(). Also rename the kernel
> pgd/p4d pointers to pgd_k/p4d_k so that their names are consistent in
> the file.

I have no idea to which branch this might apply. The first patch applies
cleanly on linus head, but this one fails in hunk #2 on everything I
tried. Can you please check?

Thanks,

	tglx