linux-kernel - Re: [PATCH v2 3/3] serial: core: Allow skipping old serial port initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jJXNK3h5P-YzRJ3hxBer305ik4FHuhcixzprnRnefU7Qw@mail.gmail.com>
Date:   Wed, 14 Mar 2018 16:00:38 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Daniel Kurtz <djkurtz@...omium.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Aaron Durbin <adurbin@...omium.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>, Jiri Slaby <jslaby@...e.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Matthias Brugger <mbrugger@...e.com>,
        David Howells <dhowells@...hat.com>,
        Vignesh R <vigneshr@...com>, Sean Young <sean@...s.org>,
        Jeffy Chen <jeffy.chen@...k-chips.com>,
        Douglas Anderson <dianders@...omium.org>,
        Matt Redfearn <matt.redfearn@...s.com>,
        Marc Gonzalez <marc_gonzalez@...madesigns.com>,
        "open list:ACPI" <linux-acpi@...r.kernel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] serial: core: Allow skipping old serial port initialization

On Wed, Mar 14, 2018 at 3:58 PM, Kees Cook <keescook@...omium.org> wrote:
> On Wed, Mar 14, 2018 at 2:44 PM, Daniel Kurtz <djkurtz@...omium.org> wrote:
> Sorry for being dense. What tree is this against? I can't find mention
> of amdcz in Linus's tree nor linux-next.

As I watched this email send, I noticed the "3/3" in the Subject. ;) I
see the amdcz support now. :P
https://patchwork.kernel.org/project/LKML/list/?submitter=18441

>> diff --git a/include/linux/serial_8250.h b/include/linux/serial_8250.h
>> index a27ef5f56431..02570edaddd8 100644
>> --- a/include/linux/serial_8250.h
>> +++ b/include/linux/serial_8250.h
>> @@ -136,6 +136,12 @@ struct uart_8250_port {
>>         struct uart_8250_em485 *em485;
>>  };
>>
>> +#ifdef CONFIG_SERIAL_8250
>> +extern bool serial8250_skip_old_ports;
>> +#else
>> +static const bool serial8250_skip_old_ports;
>> +#endif
>
> Where does serial8250_skip_old_ports get used where CONFIG_SERIAL_8250
> isn't defined? (i.e. why is the #ifdef needed here?)

This question still stands, though.

-Kees

-- 
Kees Cook
Pixel Security