linux-kernel - Re: [PATCH] lan78xx: Connect phy early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180314232520.GB16379@lunn.ch>
Date:   Thu, 15 Mar 2018 00:25:20 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Alexander Graf <agraf@...e.de>
Cc:     woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com,
        netdev@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Thomas Bogendoerfer <tbogendoerfer@...e.de>,
        Phil Elwell <phil@...pberrypi.org>
Subject: Re: [PATCH] lan78xx: Connect phy early

> @@ -2082,8 +2082,6 @@ static int lan78xx_phy_init(struct lan78xx_net *dev)
>  
>  	dev->fc_autoneg = phydev->autoneg;
>  
> -	phy_start(phydev);
> -
>  	netif_dbg(dev, ifup, dev->net, "phy initialised successfully");
>  
>  	return 0;
> @@ -2512,9 +2510,7 @@ static int lan78xx_open(struct net_device *net)
>  	if (ret < 0)
>  		goto done;
>  
> -	ret = lan78xx_phy_init(dev);
> -	if (ret < 0)
> -		goto done;
> +	phy_start(net->phydev);

Should the debug message be moved as well?

       Andrew