linux-kernel - Re: [PATCH v5 25/36] drm/bridge: analogix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Mar 2018 12:22:24 +0530
From:   Archit Taneja <architt@...eaurora.org>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        inki.dae@...sung.com, thierry.reding@...il.com, hjc@...k-chips.com,
        seanpaul@...omium.org, airlied@...ux.ie, tfiga@...omium.org,
        heiko@...ech.de
Cc:     dri-devel@...ts.freedesktop.org, dianders@...omium.org,
        a.hajda@...sung.com, ykk@...k-chips.com, kernel@...labora.com,
        m.szyprowski@...sung.com, linux-samsung-soc@...r.kernel.org,
        jy0922.shim@...sung.com, rydberg@...math.org, krzk@...nel.org,
        linux-rockchip@...ts.infradead.org, kgene@...nel.org,
        linux-input@...r.kernel.org, orjan.eide@....com,
        wxt@...k-chips.com, jeffy.chen@...k-chips.com,
        linux-arm-kernel@...ts.infradead.org, mark.yao@...k-chips.com,
        wzz@...k-chips.com, hl@...k-chips.com, jingoohan1@...il.com,
        sw0312.kim@...sung.com, linux-kernel@...r.kernel.org,
        kyungmin.park@...sung.com, Laurent.pinchart@...asonboard.com,
        kuankuan.y@...il.com, hshi@...omium.org
Subject: Re: [PATCH v5 25/36] drm/bridge: analogix_dp: Properly log AUX CH
 errors



On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote:
> From: Douglas Anderson <dianders@...omium.org>
> 
> The code in analogix_dp_transfer() that was supposed to print out:
>    AUX CH error happened
> 
> Was actually dead code. That's because the previous check (whether
> the interrupt status indicated any errors) would have hit for all
> errors anyway.
> 
> Let's combine the two error checks so we can actually see AUX CH
> errors.  We'll also downgrade the message to a warning since some of
> these types of errors might be expected for some displays.  If this
> gets too noisy we can downgrade again to debug.

Reviewed-by: Archit Taneja <architt@...eaurora.org>

Thanks,
Archit

> 
> Cc: 征增 王 <wzz@...k-chips.com>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> Signed-off-by: Sean Paul <seanpaul@...omium.org>
> Signed-off-by: Thierry Escande <thierry.escande@...labora.com>
> Reviewed-by: Andrzej Hajda <a.hajda@...sung.com>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> Tested-by: Marek Szyprowski <m.szyprowski@...sung.com>
> ---
> 
>   drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 13 +++++--------
>   1 file changed, 5 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
> index 4eae206ec31b..58e8a28e99aa 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
> @@ -1105,6 +1105,7 @@ ssize_t analogix_dp_transfer(struct analogix_dp_device *dp,
>   			     struct drm_dp_aux_msg *msg)
>   {
>   	u32 reg;
> +	u32 status_reg;
>   	u8 *buffer = msg->buffer;
>   	unsigned int i;
>   	int num_transferred = 0;
> @@ -1193,16 +1194,12 @@ ssize_t analogix_dp_transfer(struct analogix_dp_device *dp,
>   
>   	/* Clear interrupt source for AUX CH access error */
>   	reg = readl(dp->reg_base + ANALOGIX_DP_INT_STA);
> -	if (reg & AUX_ERR) {
> +	status_reg = readl(dp->reg_base + ANALOGIX_DP_AUX_CH_STA);
> +	if ((reg & AUX_ERR) || (status_reg & AUX_STATUS_MASK)) {
>   		writel(AUX_ERR, dp->reg_base + ANALOGIX_DP_INT_STA);
> -		goto aux_error;
> -	}
>   
> -	/* Check AUX CH error access status */
> -	reg = readl(dp->reg_base + ANALOGIX_DP_AUX_CH_STA);
> -	if ((reg & AUX_STATUS_MASK)) {
> -		dev_err(dp->dev, "AUX CH error happened: %d\n\n",
> -			reg & AUX_STATUS_MASK);
> +		dev_warn(dp->dev, "AUX CH error happened: %#x (%d)\n",
> +			 status_reg & AUX_STATUS_MASK, !!(reg & AUX_ERR));
>   		goto aux_error;
>   	}
>   
>