lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Mar 2018 13:14:40 +1100 From: Michael Ellerman <mpe@...erman.id.au> To: Thiago Jung Bauermann <bauerman@...ux.vnet.ibm.com>, Dave Young <dyoung@...hat.com> Cc: AKASHI Takahiro <takahiro.akashi@...aro.org>, vgoyal@...hat.com, bhe@...hat.com, prudo@...ux.vnet.ibm.com, kexec@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org Subject: Re: [PATCH v2 2/7] kexec_file, x86, powerpc: factor out kexec_file_ops functions Thiago Jung Bauermann <bauerman@...ux.vnet.ibm.com> writes: > Dave Young <dyoung@...hat.com> writes: > >> On 03/06/18 at 07:22pm, AKASHI Takahiro wrote: >>> As arch_kexec_kernel_image_{probe,load}(), >>> arch_kimage_file_post_load_cleanup() and arch_kexec_kernel_verify_sig() >>> are almost duplicated among architectures, they can be commonalized with >>> an architecture-defined kexec_file_ops array. So let's factor them out. >>> >>> Signed-off-by: AKASHI Takahiro <takahiro.akashi@...aro.org> >>> Cc: Dave Young <dyoung@...hat.com> >>> Cc: Vivek Goyal <vgoyal@...hat.com> >>> Cc: Baoquan He <bhe@...hat.com> >>> Cc: Michael Ellerman <mpe@...erman.id.au> >>> Cc: Thiago Jung Bauermann <bauerman@...ux.vnet.ibm.com> >>> --- >>> arch/powerpc/include/asm/kexec.h | 2 +- >>> arch/powerpc/kernel/kexec_elf_64.c | 2 +- >>> arch/powerpc/kernel/machine_kexec_file_64.c | 39 ++----------------- >>> arch/x86/include/asm/kexec-bzimage64.h | 2 +- >>> arch/x86/kernel/kexec-bzimage64.c | 2 +- >>> arch/x86/kernel/machine_kexec_64.c | 45 +--------------------- >>> include/linux/kexec.h | 13 +++---- >>> kernel/kexec_file.c | 60 +++++++++++++++++++++++++++-- >>> 8 files changed, 71 insertions(+), 94 deletions(-) >>> >> >> For this patch it also needs some review from powerpc people. > > FWIW: > > Reviewed-by: Thiago Jung Bauermann <bauerman@...ux.vnet.ibm.com> > > Also, tested on a ppc64le KVM guest: > > Tested-by: Thiago Jung Bauermann <bauerman@...ux.vnet.ibm.com> Thanks for testing. It looks OK to me. Acked-by: Michael Ellerman <mpe@...erman.id.au> (powerpc) cheers
Powered by blists - more mailing lists