linux-kernel - Re: [PATCHv3 0/2] zsmalloc/zram: drop zram's max_zpage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180314150713.GA144952@rodete-laptop-imager.corp.google.com>
Date:   Thu, 15 Mar 2018 00:07:13 +0900
From:   Minchan Kim <minchan@...nel.org>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>
Subject: Re: [PATCHv3 0/2] zsmalloc/zram: drop zram's max_zpage_size

On Wed, Mar 14, 2018 at 05:18:31PM +0900, Sergey Senozhatsky wrote:
> Hello,
> 
> 	ZRAM's max_zpage_size is a bad thing. It forces zsmalloc to
> store normal objects as huge ones, which results in bigger zsmalloc
> memory usage. Drop it and use actual zsmalloc huge-class value when
> decide if the object is huge or not.
> 
> v3:
> - add pool param to zs_huge_class_size() [Minchan]
> 
> Sergey Senozhatsky (2):
>   zsmalloc: introduce zs_huge_class_size() function
>   zram: drop max_zpage_size and use zs_huge_class_size()
 
Both looks good to me.

Acked-by: Minchan Kim <minchan@...nel.org>

Thanks.