linux-kernel - Re: [PATCH] jump_label: Fix sparc64 warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180314.124633.1173391181334136968.davem@davemloft.net>
Date:   Wed, 14 Mar 2018 12:46:33 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     jpoimboe@...hat.com
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org, mingo@...nel.org,
        peterz@...radead.org, jbaron@...mai.com, bp@...e.de
Subject: Re: [PATCH] jump_label: Fix sparc64 warning

From: Josh Poimboeuf <jpoimboe@...hat.com>
Date: Wed, 14 Mar 2018 10:24:20 -0500

> The kbuild test robot reported the following warning on sparc64:
> 
>   kernel/jump_label.c: In function '__jump_label_update':
>   kernel/jump_label.c:376:51: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>        WARN_ONCE(1, "can't patch jump_label at %pS", (void *)entry->code);
> 
> On sparc64, the jump_label entry->code field is of type u32, but
> pointers are 64-bit.  Silence the warning by casting entry->code to an
> unsigned long before casting it to a pointer.  This is also what the
> sparc jump label code does.
> 
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Fixes: dc1dd184c2f0 ("jump_label: Warn on failed jump_label patching attempt")
> Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>

Acked-by: David S. Miller <davem@...emloft.net>