linux-kernel - Re: [PATCH 4.4 24/36] netlink: ensure to loop over all netns in genlmsg_multicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d37d5d6a-2b5d-184b-470b-25a97910988b@6wind.com>
Date:   Wed, 14 Mar 2018 18:06:17 +0100
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     Ben Hutchings <ben.hutchings@...ethink.co.uk>,
        "David S. Miller" <davem@...emloft.net>
Cc:     stable@...r.kernel.org, Johannes Berg <johannes.berg@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4.4 24/36] netlink: ensure to loop over all netns in
 genlmsg_multicast_allns()

Le 13/03/2018 à 01:04, Ben Hutchings a écrit :
> On Fri, 2018-03-09 at 16:18 -0800, Greg Kroah-Hartman wrote:
>> 4.4-stable review patch.  If anyone has any objections, please let me know.
>>
>> ------------------
>>
>> From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
>>
>>
>> [ Upstream commit cb9f7a9a5c96a773bbc9c70660dc600cfff82f82 ]
> [...] 
>> -	return nlmsg_multicast(prev->genl_sock, skb, portid, group, flags);
>> +	err = nlmsg_multicast(prev->genl_sock, skb, portid, group, flags);
>> +	if (!err)
>> +		delivered = true;
>> +	else if (err != -ESRCH)
>> +		goto error;
> 
> This call to nlmsg_multicast() consumes skb rather than a clone, so we
> must not free it again here.
Right, good catch.

I will send an update.

Regards,
Nicolas