linux-kernel - Re: [PATCH 2/7] kbuild: touch autoksyms.h when it is really missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YSQ.7.76.1803141324420.28583@knanqh.ubzr>
Date:   Wed, 14 Mar 2018 13:26:35 -0400 (EDT)
From:   Nicolas Pitre <nicolas.pitre@...aro.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
cc:     linux-kbuild@...r.kernel.org, Jarod Wilson <jarod@...hat.com>,
        Prarit Bhargava <prarit@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] kbuild: touch autoksyms.h when it is really
 missing

On Thu, 15 Mar 2018, Masahiro Yamada wrote:

> From the comment, I expect this code creates autoksyms.h in case it
> is missing, but it actually touches it when it does exists.

Oops, indeed.

> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
> I do not know when this code is useful...
> 
> If autoksyms.h were missing, build should have already failed because
> include/{linux,asm-generic}/export.h need it.
> 
> Maybe for standalone test?
> Or, in order to make this script self-contained?

I agree it isn't very useful. Proof: it was wrong and wouldn't have 
worked as intended. So the best fix might be to simply remove that line.



> 
> 
>  scripts/adjust_autoksyms.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/adjust_autoksyms.sh b/scripts/adjust_autoksyms.sh
> index 513da1a..a52210b 100755
> --- a/scripts/adjust_autoksyms.sh
> +++ b/scripts/adjust_autoksyms.sh
> @@ -49,7 +49,7 @@ case "${KCONFIG_CONFIG}" in
>  esac
>  
>  # In case it doesn't exist yet...
> -if [ -e "$cur_ksyms_file" ]; then touch "$cur_ksyms_file"; fi
> +if [ ! -e "$cur_ksyms_file" ]; then touch "$cur_ksyms_file"; fi
>  
>  # Generate a new ksym list file with symbols needed by the current
>  # set of modules.
> -- 
> 2.7.4
> 
>